engine_getBlobsV2: add partialResponse flag to enable partial hits#669
Closed
raulk wants to merge 1 commit intoethereum:mainfrom
Closed
engine_getBlobsV2: add partialResponse flag to enable partial hits#669raulk wants to merge 1 commit intoethereum:mainfrom
engine_getBlobsV2: add partialResponse flag to enable partial hits#669raulk wants to merge 1 commit intoethereum:mainfrom
Conversation
Add optional `partialResponse` boolean flag to reinstate `engine_getBlobsV1`'s partial hit behavior, needed for optimization work. Background: - `engine_getBlobsV1` currently achieves a 70-80% hit rate, expected to remain high even as blob volume increases. - EIP-4844 introduced full blob sidecar broadcasts at the CL layer; with PeerDAS, the CL now gossips column sidecars. - Because columns sidecars require all cells to be present, support for partial hits was previously dropped [in this commit][cad419]. Motivation: - The P2P networking team is actively working on backwards-compatible optimizations that can be deployed in-between forks. - For instance, we're prototyping cell-level deltas to facilitate column reconciliation based on local availability. - This would reduce redundant full-column transmissions and reclaim useful bandwith to further scale blobs. Remarks: - We're aware this change might be procedurally late, but its ease of implementation and its ability to unlock an entire class of interim improvements makes it worthwhile to consider (and we only noticed this opportunity in Berlin). - We'll happily submit PRs to implement this in EL and CL clients if needed. Just let us know! - We gated partial responses behind a flag to avoid unnecessary overhead while unused. [cad419]: ethereum@cad4194
Contributor
|
I have a general question. What stops us from making |
3 tasks
Contributor
|
From the ACDT discussion on Monday, there seems consensus to go back to the old behavior of returning partial responses with null for missing blobs, as opposed to introduce a new flag. |
Member
Author
|
Superseded by #671 based on ACDT discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
partialResponseboolean flag to reinstateengine_getBlobsV1's partial hit behavior, needed for optimization work.Background
engine_getBlobsV1currently achieves a 70-80% hit rate, expected to remain high even as blob volume increases.Motivation
Remarks